Ian Maxon has posted comments on this change. Change subject: [ASTERIXDB-2231][STO] Separate primary op tracker for each partition ......................................................................
Patch Set 15: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2263/15/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/ComponentRollbackTest.java: PS15, Line 105: private static final int PARTITION_ID = 1; why 1 when there's use of partition 0 in the index creation? https://asterix-gerrit.ics.uci.edu/#/c/2263/15/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java: PS15, Line 158: public synchronized void addIndex(long resourceID, IndexInfo indexInfo) { : indexes.put(resourceID, indexInfo); : partitionIndexes.computeIfAbsent(indexInfo.getPartition(), partition -> new HashSet<>()).add(indexInfo); : } Wait, how'd this get mapped in before without this method and its complement? https://asterix-gerrit.ics.uci.edu/#/c/2263/15/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: PS15, Line 221: for (PrimaryIndexOperationTracker opTracker : dsr.getOpTrackers()) { : if (opTracker.getNumActiveOperations() != 0) { : return false; : } is there some way that the number of active operations could increment on an optracker after it's checked here but before the loop finishes? Line 441: logRecord.wait(); > CRITICAL SonarQube violation: idk why sonar says this is critical but the rule says minor? -- To view, visit https://asterix-gerrit.ics.uci.edu/2263 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eb3854d2343e45beeccb87b0d434e5f4efd69c9 Gerrit-PatchSet: 15 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
