Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2244][RTM] Implement micro union-all operator ......................................................................
Patch Set 9: Code-Review+2 (5 comments) Please address comments and add one (or more) optimizer tests in a follow up change. https://asterix-gerrit.ics.uci.edu/#/c/2277/8//COMMIT_MSG Commit Message: PS8, Line 7: RTM RT https://cwiki.apache.org/confluence/display/ASTERIXDB/Formatting https://asterix-gerrit.ics.uci.edu/#/c/2277/9/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansAccumulatingAggregatorFactory.java: PS9, Line 171: [0] Fail if there is more than 1 element in the array. https://asterix-gerrit.ics.uci.edu/#/c/2277/9/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/aggreg/NestedPlansRunningAggregatorFactory.java: PS9, Line 152: [0] Fail if there's more than 1 runtime in the array. https://asterix-gerrit.ics.uci.edu/#/c/2277/9/hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java File hyracks-fullstack/algebricks/algebricks-runtime/src/main/java/org/apache/hyracks/algebricks/runtime/operators/meta/PipelineAssembler.java: PS9, Line 73: if Can we throw in the else-case? https://asterix-gerrit.ics.uci.edu/#/c/2277/9/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/job/JobSpecification.java: PS9, Line 88: private transient int operatorIdCounter; : : private transient int connectorIdCounter; : : private transient List<IOperatorDescriptor> metaOps; Could these be part of a "construction context"? -- To view, visit https://asterix-gerrit.ics.uci.edu/2277 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11be926f175889978c144dd4483ec565d3d86e2d Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
