abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2231][STO] Separate primary op tracker for each partition ......................................................................
Patch Set 18: (3 comments) Looks good. Minor comments. FYI, took long because we believe the area of DatasetLifecycleManager needs some housekeeping in general and I wanted to make it part of this change. However, turned out the amount of work needed to do that would be substantial. The main idea is that the root resource manager should only care about partitions. Each partition should care about dataset partitions, and each dataset partition would care about a single primary and a set of secondary indexes. Anyway, we decided to push that back. https://asterix-gerrit.ics.uci.edu/#/c/2263/18/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetInfo.java: PS18, Line 76: etDatasetPartitionIn let's rename to getDatasetPartitionOpenIndexes ? since this only cares about the open ones https://asterix-gerrit.ics.uci.edu/#/c/2263/18/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/context/DatasetLifecycleManager.java: Line 443: } catch (InterruptedException e) { > CRITICAL SonarQube violation: +1 PS18, Line 620: public int getResourcePartition(String resourcePath) throws HyracksDataException { : // parse partition from the resource path : // NOTE: we cannot get partition from resourceRepository, since this method could be called during : // an index resource is being created : return StoragePathUtil.getPartitionNumFromRelativePath(resourcePath); : } why not remove this from the interface and simply call the Util? -- To view, visit https://asterix-gerrit.ics.uci.edu/2263 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9eb3854d2343e45beeccb87b0d434e5f4efd69c9 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
