Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-1972][COMP][RT][TX] index-only plan ......................................................................
Patch Set 50: (2 comments) A couple of comments. Still reviewing this, so not done yet. https://asterix-gerrit.ics.uci.edu/#/c/1866/50/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java: PS50, Line 92: firstValueForappendOpCallbackProceedResult firstValue/secondValue is a bit confusing. Not clear which corresponds to false and which to true. Let's rename them into searchCallbackProceedResultTrueValue and searchCallbackProceedResultFalseValue Line 170: buildMissingTuple(numIndexFilterFields, nonFilterTupleBuild, nonMatchWriter); I think the issue with the last field is still present. If 'appendSearchCallbackProceedResut' is set to true then buildMissingTuple() invoked from here will write 'secondValueForappendOpCallbackProceedResult' as the last field instead of MISSING. I suggest we take appendSearchCallbackProceedResult handling out of buildMIssingTuple() and handle it in this method. So after buildMIssinTuple() is called from (if (retainMissing)) block above we'll add 'secondValueForappendOpCallbackProceedResult' as the last field into the created tuple. That way buildMissingTuple() can remain the same as it used to be. -- To view, visit https://asterix-gerrit.ics.uci.edu/1866 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5c9ab1cf2e4bedb7d8db582441919875e74d51 Gerrit-PatchSet: 50 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: Yingyi Bu <buyin...@gmail.com> Gerrit-HasComments: Yes
