Ian Maxon has posted comments on this change.

Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type 
and functions
......................................................................


Patch Set 6:

(3 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/dataflow/data/nontagged/serde/AGeometrySerializerDeserializer.java:

PS6, Line 49:             OGCGeometry geometry = OGCGeometry
            :                     
.createFromOGCStructure(OperatorImportFromWkb.local().executeOGC(0, buffer, 
null),
            :                             SpatialReference.create(4326))
> The parameter 0 uses the default import flags in JTS.
They should both be static final variables then, the numbers.


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java
File 
asterixdb/asterix-om/src/main/java/org/apache/asterix/om/base/AGeometry.java:

Line 73:             throw new RuntimeException(e);
> We're bound here to the signature of JSONSerializable#toJSON which does not
I suppose it's fine in that case, unfortunate consequence of the interface.


https://asterix-gerrit.ics.uci.edu/#/c/2056/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java
File 
asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/aggregates/std/STUnionAggregateFunction.java:

PS6, Line 66: geometry = new OGCPoint(new Point(), 
SpatialReference.create(4326));
            :     }
> 4326 is the ID of the WGS84 CRS which is the default one used by most appli
That should definitely be a static final variable then.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289
Gerrit-PatchSet: 6
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Ahmed Eldawy <eld...@cs.umn.edu>
Gerrit-Reviewer: Ahmed Eldawy <aseld...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to