Ahmed Eldawy has posted comments on this change.
Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type
Patch Set 7:
I didn't test its memory consumption but my understanding is that it will
create as many Java objects as the number of records in the input. I understand
how bad it is but this is the price of using the existing Esri library. It is
not really optimized for streaming data from a binary stream where it reuses
the same object over and over. I don't see anyway around it without changing
the Esri library itself. However, we can probably have our own implementation
for the easy functions (e.g., XMin and XMax) which does not create any objects
and processes it from the binary stream. But we will still rely on Esri for the
complex functions (e.g., Union and Intersect for multipolygon.
> (4 comments)
> Has this been benchmarked for memory consumption? I see a lot of
> places that look like to me, they will consume memory in proportion
> to the data perhaps...
PS6, Line 49: OGCGeometry geometry =
buffer, null), SpatialReference.create(4326));
: return new AGeometry(geometry);
> They should both be static final variables then, the numbers.
PS6, Line 66:
> That should definitely be a static final variable then.
Line 104: }
> Maybe use this UnsupportedItemTypeException?
To view, visit https://asterix-gerrit.ics.uci.edu/2056
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-Owner: Ahmed Eldawy <eld...@cs.umn.edu>
Gerrit-Reviewer: Ahmed Eldawy <aseld...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Ian Maxon <ima...@apache.org>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com>