Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE] More multi-CC support, ConfigManager updates ......................................................................
Patch Set 6: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2344/6/asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITxnIdFactory.java File asterixdb/asterix-common/src/main/java/org/apache/asterix/common/transactions/ITxnIdFactory.java: PS6, Line 24: TxnId create() throws AlgebricksException; : : void ensureMinimumId(long id) throws AlgebricksException; javadocs https://asterix-gerrit.ics.uci.edu/#/c/2344/6/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java: PS6, Line 1080: ACIDException this is runtime, it doesn't have to be here https://asterix-gerrit.ics.uci.edu/#/c/2344/6/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataNode.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/api/IMetadataNode.java: PS6, Line 57: Allocates a block of transaction ids of specified block size fix https://asterix-gerrit.ics.uci.edu/#/c/2344/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/CcTxnIdFactory.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/utils/CcTxnIdFactory.java: PS6, Line 34: /*package*/ remove https://asterix-gerrit.ics.uci.edu/#/c/2344/6/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java File hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java: PS6, Line 340: used use PS6, Line 351: used use -- To view, visit https://asterix-gerrit.ics.uci.edu/2344 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff60887bf71ce3f3ed7201afd9499612bfc83485 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
