Murtadha Hubail has posted comments on this change.

Change subject: [ASTERIXDB-2276][CONF] Introduce Max Active Writable Datasets
......................................................................


Patch Set 1:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2362/1//COMMIT_MSG
Commit Message:

PS1, Line 19: - Introduce max active writable datasets and use
            :   it to automatically calculate the number of pages
            :   of a user dataset memory component.
> Hard to say. For me, I would rather configure storage.memorycomponent.numpa
>From research point of view, I totally understand your point of view. However, 
>as a user, I should know the minimum datasets my application needs. The 
>description of this parameter can be made clear that miss setting it will 
>greatly impact the performance of ingestion. As you already mentioned, 
>currently, we allocate memory for the whole dataset, including all of its 
>partitions and indexes. When that problem is solve, the budget allocated using 
>the new parameter can be used to determine the rest. As for the dynamically 
>allocating a shared virtual buffer cache, we thought about it and we wanted to 
>solve the problem of running out of memory using it. However, since 
>implementing it will greatly change the current structure of memory 
>management, we decided to defer its implementation.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2362
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9909c26b1e12b431f913e201d2c3d83769be7269
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhub...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Luo Chen <cl...@uci.edu>
Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org>
Gerrit-HasComments: Yes

Reply via email to