Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2281][RT] Consider reserved txn ids when determining max ......................................................................
Patch Set 3: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2368/3/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/MetadataManager.java: PS3, Line 1007: public static ILongBlockFactory getTxnIdBlockFactory() { : try { : INSTANCE.init(); : } catch (HyracksDataException e) { : throw new IllegalStateException(e); : } : return (ILongBlockFactory) INSTANCE; : : } this should be removed now. https://asterix-gerrit.ics.uci.edu/#/c/2368/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportLocalCountersMessage.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/ReportLocalCountersMessage.java: PS3, Line 68: Math.max(appContext.getMaxTxnId(), : appContext.getTransactionSubsystem().getTransactionManager().getMaxTxnId()); Let's do the max in NCAppRuntimeContext itself so that this logic will be centralized there instead of this msg. In there, you will need to check if (txnSubsystem == null) and throw IllegalStateException if it is the case to prevent someone from calling getMaxTxnId before TransactionSubsystem is initialized. https://asterix-gerrit.ics.uci.edu/#/c/2368/3/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequestResponseMessage.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/message/TxnIdBlockRequestResponseMessage.java: PS3, Line 25: TxnIdBlockRequestResponseMessage I don't have a strong opinion but with the naming convention we have been following for messages this should be renamed to TxnIdBlockResponseMessage -- To view, visit https://asterix-gerrit.ics.uci.edu/2368 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I88f14fb351976db239ed752693e59882da62d588 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-HasComments: Yes
