Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2204][STO] Fix implementations and usages of IIndexCursor ......................................................................
Patch Set 17: (7 comments) https://asterix-gerrit.ics.uci.edu/#/c/2324/17/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/dataflow/FeedRecordDataFlowController.java: PS17, Line 124: if (failure != null) { : if (failure instanceof InterruptedException) { : throw (InterruptedException) failure; : } : HyracksDataException.throwIfNotNull(failure); : } HyracksDataException.throwIfNotNull(failure);? https://asterix-gerrit.ics.uci.edu/#/c/2324/17/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/indexing/ExternalFileIndexAccessor.java: PS17, Line 144: if (failure != null) { : throw HyracksDataException.create(failure); : } HyracksDataException.throwIfNotNull(failure);? https://asterix-gerrit.ics.uci.edu/#/c/2324/17/asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java File asterixdb/asterix-external-data/src/main/java/org/apache/asterix/external/util/DataflowUtils.java: PS17, Line 110: loggingFailure ignore https://asterix-gerrit.ics.uci.edu/#/c/2324/17/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/DestroyUtils.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/DestroyUtils.java: PS17, Line 59: loggingFailure ignore https://asterix-gerrit.ics.uci.edu/#/c/2324/17/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/util/ResourceReleaseUtils.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/util/ResourceReleaseUtils.java: PS17, Line 48: IIndexCursor again, I think you can come up with an interface like IDestroyable here https://asterix-gerrit.ics.uci.edu/#/c/2324/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeDiskComponentScanCursor.java: PS17, Line 196: if (failure != null) { : throw HyracksDataException.create(failure); : } throwIfNotNull https://asterix-gerrit.ics.uci.edu/#/c/2324/17/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/LSMBTreeOpContext.java: PS17, Line 207: if (failure != null) { : throw HyracksDataException.create(failure); : } throw if not null -- To view, visit https://asterix-gerrit.ics.uci.edu/2324 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98a7a8b931eb24dbe11bf2bdc61b754ca28ebdf9 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
