Michael Blow has uploaded a new change for review.
https://asterix-gerrit.ics.uci.edu/2383
Change subject: [NO ISSUE] Use enum for Statement.Kind
......................................................................
[NO ISSUE] Use enum for Statement.Kind
Change-Id: If3cf2a315dfd6330c06c00a4b9c752db2b2d06fe
---
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
M
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
9 files changed, 18 insertions(+), 63 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb-bad
refs/changes/83/2383/1
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
index 90beef7..485a1e1 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/BrokerDropStatement.java
@@ -18,7 +18,7 @@
*/
package org.apache.asterix.bad.lang.statement;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.lang.BADLangExtension;
import org.apache.asterix.bad.metadata.Broker;
@@ -34,7 +34,7 @@
import org.apache.hyracks.api.client.IHyracksClientConnection;
import org.apache.hyracks.api.exceptions.HyracksDataException;
-public class BrokerDropStatement implements IExtensionStatement {
+public class BrokerDropStatement extends ExtensionStatement {
private final Identifier dataverseName;
private final Identifier brokerName;
@@ -56,11 +56,6 @@
public Identifier getBrokerName() {
return brokerName;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
index e4b6d89..3d43ee6 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelDropStatement.java
@@ -23,7 +23,7 @@
import java.util.logging.Logger;
import org.apache.asterix.active.EntityId;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.active.ActiveNotificationHandler;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.BADConstants;
@@ -45,7 +45,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.DeployedJobSpecId;
-public class ChannelDropStatement implements IExtensionStatement {
+public class ChannelDropStatement extends ExtensionStatement {
private static final Logger LOGGER =
Logger.getLogger(ChannelDropStatement.class.getName());
private final Identifier dataverseName;
@@ -68,11 +68,6 @@
public boolean getIfExists() {
return ifExists;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
index bab6ad2..5f08845 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelSubscribeStatement.java
@@ -21,7 +21,7 @@
import java.util.ArrayList;
import java.util.List;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.BADConstants;
import org.apache.asterix.bad.lang.BADLangExtension;
@@ -59,7 +59,7 @@
import org.apache.hyracks.api.dataset.ResultSetId;
import org.apache.hyracks.api.exceptions.HyracksDataException;
-public class ChannelSubscribeStatement implements IExtensionStatement {
+public class ChannelSubscribeStatement extends ExtensionStatement {
private final Identifier dataverseName;
private final Identifier channelName;
@@ -106,11 +106,6 @@
public String getSubscriptionId() {
return subscriptionId;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
index e456768..79c8efd 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ChannelUnsubscribeStatement.java
@@ -21,7 +21,7 @@
import java.util.ArrayList;
import java.util.List;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.BADConstants;
import org.apache.asterix.bad.lang.BADLangExtension;
@@ -51,7 +51,7 @@
import org.apache.hyracks.api.client.IHyracksClientConnection;
import org.apache.hyracks.api.exceptions.HyracksDataException;
-public class ChannelUnsubscribeStatement implements IExtensionStatement {
+public class ChannelUnsubscribeStatement extends ExtensionStatement {
private final Identifier dataverseName;
private final Identifier channelName;
@@ -86,11 +86,6 @@
public int getVarCounter() {
return varCounter;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
index 6369854..99aded8 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateBrokerStatement.java
@@ -21,7 +21,7 @@
import java.util.logging.Level;
import java.util.logging.Logger;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.lang.BADLangExtension;
import org.apache.asterix.bad.metadata.Broker;
@@ -37,7 +37,7 @@
import org.apache.hyracks.api.client.IHyracksClientConnection;
import org.apache.hyracks.api.exceptions.HyracksDataException;
-public class CreateBrokerStatement implements IExtensionStatement {
+public class CreateBrokerStatement extends ExtensionStatement {
private static final Logger LOGGER =
Logger.getLogger(CreateBrokerStatement.class.getName());
private final Identifier dataverseName;
@@ -60,11 +60,6 @@
public Identifier getBrokerName() {
return brokerName;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
index 53baf6d..c3c9a1e 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
@@ -30,7 +30,7 @@
import org.apache.asterix.active.DeployedJobService;
import org.apache.asterix.active.EntityId;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.active.ActiveNotificationHandler;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.BADConstants;
@@ -80,7 +80,7 @@
import org.apache.hyracks.api.job.JobSpecification;
import org.apache.hyracks.dataflow.common.data.parsers.IValueParser;
-public class CreateChannelStatement implements IExtensionStatement {
+public class CreateChannelStatement extends ExtensionStatement {
private static final Logger LOGGER =
Logger.getLogger(CreateChannelStatement.class.getName());
private final Identifier channelName;
@@ -160,11 +160,6 @@
ByteArrayOutputStream bos = new ByteArrayOutputStream();
DataOutputStream outputStream = new DataOutputStream(bos);
durationParser.parse(duration.toCharArray(), 0,
duration.toCharArray().length, outputStream);
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
private void createDatasets(IStatementExecutor statementExecutor,
MetadataProvider metadataProvider,
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
index 0908edb..cab66c2 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateProcedureStatement.java
@@ -27,7 +27,7 @@
import java.util.logging.Logger;
import org.apache.asterix.active.EntityId;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.active.ActiveNotificationHandler;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.BADConstants;
@@ -78,7 +78,7 @@
import org.apache.hyracks.api.job.JobSpecification;
import org.apache.hyracks.dataflow.common.data.parsers.IValueParser;
-public class CreateProcedureStatement implements IExtensionStatement {
+public class CreateProcedureStatement extends ExtensionStatement {
private static final Logger LOGGER =
Logger.getLogger(CreateProcedureStatement.class.getName());
@@ -114,11 +114,6 @@
public Statement getProcedureBodyStatement() {
return procedureBodyStatement;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
public List<String> getParamList() {
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
index 7db935a..b597f98 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ExecuteProcedureStatement.java
@@ -26,7 +26,7 @@
import org.apache.asterix.active.DeployedJobService;
import org.apache.asterix.active.EntityId;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.api.http.server.ResultUtil;
import org.apache.asterix.app.active.ActiveNotificationHandler;
import org.apache.asterix.app.result.ResultReader;
@@ -62,7 +62,7 @@
import org.apache.hyracks.api.job.JobId;
import org.apache.hyracks.data.std.util.ArrayBackedValueStorage;
-public class ExecuteProcedureStatement implements IExtensionStatement {
+public class ExecuteProcedureStatement extends ExtensionStatement {
public static final String WAIT_FOR_COMPLETION =
"wait-for-completion-procedure";
@@ -88,11 +88,6 @@
public int getArity() {
return arity;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
diff --git
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
index f0eaced..ebde605 100644
---
a/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
+++
b/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/ProcedureDropStatement.java
@@ -23,7 +23,7 @@
import java.util.logging.Logger;
import org.apache.asterix.active.EntityId;
-import org.apache.asterix.algebra.extension.IExtensionStatement;
+import org.apache.asterix.algebra.extension.ExtensionStatement;
import org.apache.asterix.app.active.ActiveNotificationHandler;
import org.apache.asterix.app.translator.QueryTranslator;
import org.apache.asterix.bad.BADConstants;
@@ -45,7 +45,7 @@
import org.apache.hyracks.api.exceptions.HyracksDataException;
import org.apache.hyracks.api.job.DeployedJobSpecId;
-public class ProcedureDropStatement implements IExtensionStatement {
+public class ProcedureDropStatement extends ExtensionStatement {
private static final Logger LOGGER =
Logger.getLogger(ProcedureDropStatement.class.getName());
private final FunctionSignature signature;
@@ -62,11 +62,6 @@
public boolean getIfExists() {
return ifExists;
- }
-
- @Override
- public byte getKind() {
- return Kind.EXTENSION;
}
@Override
--
To view, visit https://asterix-gerrit.ics.uci.edu/2383
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3cf2a315dfd6330c06c00a4b9c752db2b2d06fe
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Michael Blow <mb...@apache.org>
