Michael Blow has posted comments on this change.

Change subject: [ASTERIXDB-2282][HTTP] Revive HTTP server on unexpected channel 
drops
......................................................................


Patch Set 7:

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2382/7/hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java
File 
hyracks-fullstack/hyracks/hyracks-http/src/main/java/org/apache/hyracks/http/server/HttpServer.java:

PS7, Line 266: true
ok, I see that this will exit on interrupt since we always set state to 
STOPPING first.  can we move the state != STARTED to this while to make it more 
clear what is happening?


PS7, Line 385: new 
StringBuilder().append('{').append("\"class\"").append(':').append('\"')
             :                 
.append(getClass().getSimpleName()).append('\"').append(',').append("\"port\"").append(':')
             :                 
.append(Integer.toString(port)).append(',').append("\"state\"").append(':').append('\"').append(state)
             :                 .append('\"').append('}').toString()
this should be replaced with String concatenation- way more readable and the 
net implementation will be better (many chained calls of string literals here).


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2382
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7da75a9e34795c94518aca243b4cef387221d8fd
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to