abdullah alamoudi has submitted this change and it was merged. Change subject: [NO ISSUE] Only close the index in the close of the Upsert Operator ......................................................................
[NO ISSUE] Only close the index in the close of the Upsert Operator - user model changes: no - storage format changes: no - interface changes: no details: - Previously, a failure in the opening of the upsert operator will cause the index to be closed twice. - After this change, we only close the index in the close call of the operator. Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Reviewed-on: https://asterix-gerrit.ics.uci.edu/2378 Sonar-Qube: Jenkins <[email protected]> Tested-by: Jenkins <[email protected]> Contrib: Jenkins <[email protected]> Integration-Tests: Jenkins <[email protected]> Reviewed-by: abdullah alamoudi <[email protected]> --- M asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java 1 file changed, 2 insertions(+), 4 deletions(-) Approvals: Anon. E. Moose #1000171: abdullah alamoudi: Looks good to me, approved Jenkins: Verified; No violations found; ; Verified diff --git a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java index 6bd9d99..e33dfb6 100644 --- a/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java +++ b/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/operators/LSMPrimaryUpsertOperatorNodePushable.java @@ -244,10 +244,8 @@ appender.write(writer, true); } }; - - } catch (Exception e) { - indexHelper.close(); - throw new HyracksDataException(e); + } catch (Throwable e) { // NOSONAR: Re-thrown + throw HyracksDataException.create(e); } } -- To view, visit https://asterix-gerrit.ics.uci.edu/2378 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d76de2781362ef5c80aa926e1112e7872049c71 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]>
