abdullah alamoudi has posted comments on this change.

Change subject: [NO ISSUE][STO] Perform IO reads in uninterruptible threads
......................................................................


Patch Set 4:

(7 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2387/4/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/buffercache/BufferCache.java:

PS4, Line 719:             while (true) {
> let's set the name on this thread
Done


PS4, Line 725: Reader thread - " + num + "
> the number can be in the thread name, which gets logged- can we just use {}
Done


PS4, Line 726:                     Thread.currentThread().interrupt();
> I think we should ignore any interrupt here, and update log message accordi
Done


PS4, Line 733: "Reader thread - " + num
             :                                 + "
> same comment above on name, etc.
Done


PS4, Line 740: BufferCache reader thread - " + num + "
> same comment above on name
Done


PS4, Line 749: "Reader thread - " + num + "
> same comment above on name
Done


PS4, Line 889: // NOSONAR will always succeed since the queue is empty
> why is the queue empty?
ops... copied it from above by mistake


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2387
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id28d57a222f42962284b24296cb9b91658e5dc77
Gerrit-PatchSet: 4
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to