Taewoo Kim has posted comments on this change.

Change subject: [ASTERIXDB-2083][COMP][RT][IDX][SITE] Budget-Constrained 
Inverted index search
......................................................................


Patch Set 30:

(10 comments)

Thanks Abdullah.

https://asterix-gerrit.ics.uci.edu/#/c/2251/29/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/exceptions/ErrorCode.java:

PS29, Line 144: CANNOT_CONTINUE_TEXT_SEARCH
> this seems to be used in many places and for different reasons. can we have
Good idea. I have separated the code.


https://asterix-gerrit.ics.uci.edu/#/c/2251/29/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/api/IInvertedListCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/api/IInvertedListCursor.java:

PS29, Line 27: IInvertedListCursor
> just a suggestion.. if we want this to be another cursor, let's extend Enfo
OK. Done.


https://asterix-gerrit.ics.uci.edu/#/c/2251/6/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListCursor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeElementInvertedListCursor.java:

Line 148:      */
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/2251/29/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeFrameTupleAppender.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/ondisk/FixedSizeFrameTupleAppender.java:

PS29, Line 34: FixedSizeFrameTupleAppender
> There is another class with the same name  (used for hash join I believe) F
This class only supports a fixed size tuple. Thus, it's simple. The class used 
for hash join actually supports variable length tuples since it has 
tupleEndOffset for each tuple at the end of a frame. So, 
this one: "FixedSizeFrameTuple"Appender
That one: "FixedSizeFrame"TupleAppender


https://asterix-gerrit.ics.uci.edu/#/c/2251/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedIndexSearchResult.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedIndexSearchResult.java:

Line 60: 
> MAJOR SonarQube violation:
Done


Line 86:         this.bufferManager = bufferManager;
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/2251/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java
File 
hyracks-fullstack/hyracks/hyracks-storage-am-lsm-invertedindex/src/main/java/org/apache/hyracks/storage/am/lsm/invertedindex/search/InvertedListMerger.java:

Line 42: 
> MAJOR SonarQube violation:
Done


Line 100:      */
> MAJOR SonarQube violation:
Done


Line 369:                     // For a final result, needs to pause when a 
frame becomes full to let the caller
> MAJOR SonarQube violation:
Done


https://asterix-gerrit.ics.uci.edu/#/c/2251/1/hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessor.java
File 
hyracks-fullstack/hyracks/hyracks-storage-common/src/main/java/org/apache/hyracks/storage/common/IIndexAccessor.java:

Line 88:      */
> MAJOR SonarQube violation:
Done


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2251
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2b2ef7c0b8c55ef66a5322be5d97ebbbf287bf5
Gerrit-PatchSet: 30
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Taewoo Kim <wangs...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wangs...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to