Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][ING] Prevent duplicate active runtimes in NCs
......................................................................


Patch Set 7:

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2392/7/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java
File 
asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java:

PS7, Line 77: throw new 
RuntimeDataException(ErrorCode.ACTIVE_RUNTIME_ALREADY_REGISTERED, 
runtime.getRuntimeId());
this is only a bug when this happens, right?  why not just use 
IllegalStateException?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2392
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7065625537f930394fa7387af2fd1e851582c86
Gerrit-PatchSet: 7
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes

Reply via email to