abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][ING] Prevent duplicate active runtimes in NCs ......................................................................
Patch Set 9: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2392/7/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java: PS7, Line 77: throw new IllegalStateException("Active Runtime " + runtime.getRuntimeId() + " is already registered > this is only a bug when this happens, right? why not just use IllegalState We can do that too https://asterix-gerrit.ics.uci.edu/#/c/2392/9/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/active/ActiveEntityEventsListener.java: PS9, Line 185: LOGGER.log(Level.WARN, "the job " + jobId + " finished with reported runtime registrations = " : + numRegistered + " and deregistrations = " + numDeRegistered + " on node controllers") > avoid string concatenation Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2392 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7065625537f930394fa7387af2fd1e851582c86 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
