Michael Blow has posted comments on this change. Change subject: [NO ISSUE][NET] Networking Improvements ......................................................................
Patch Set 2: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java File hyracks-fullstack/hyracks/hyracks-ipc/src/main/java/org/apache/hyracks/ipc/impl/IPCConnectionManager.java: PS2, Line 370: LOGGER.error(() -> new ParameterizedMessage("TCP read error from {}", handle.getRemoteAddress()), e); how does this differ from: LOGGER.error("TCP read error from {}", handle::getRemoteAddress, e); PS2, Line 394: LOGGER.error(() -> new ParameterizedMessage("TCP write error to {}", handle.getRemoteAddress()), e); see above q https://asterix-gerrit.ics.uci.edu/#/c/2418/2/hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java File hyracks-fullstack/hyracks/hyracks-net/src/main/java/org/apache/hyracks/net/protocols/tcp/TCPEndpoint.java: PS2, Line 211: LOGGER.error(() -> new ParameterizedMessage("Error in TCPEndpoint {}", localAddress), e); not asking again -- To view, visit https://asterix-gerrit.ics.uci.edu/2418 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I60c1f9cfe2ea577fca14cd2e98c6461c49df011a Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
