Till Westmann has posted comments on this change.

Change subject: [NO ISSUE][STO] Move the IO threads from BufferCache to 
IOManager
......................................................................


Patch Set 3:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java
File 
hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/util/CleanupUtils.java:

PS3, Line 120: Throwable
Suppress SQ warnings?


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/NodeControllerService.java:

PS3, Line 238: Throwable
Suppress SQ warning?


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IOManager.java:

PS3, Line 167:         try {
             :             if (req.getState() == State.OPERATION_SUCCEEDED) {
             :                 return req.getWrites();
             :             } else if (req.getState() == State.OPERATION_FAILED) 
{
             :                 throw req.getFailure();
             :             } else {
             :                 throw new IllegalStateException("Write request 
completed with state " + req.getState());
             :             }
             :         } finally {
             :             req.recycle();
             :         }
Seems identical to the methods above. Can we factor this out?


PS3, Line 205: asyncWrite
Move this close to the other asyncWrite method?


https://asterix-gerrit.ics.uci.edu/#/c/2417/3/hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequestHandler.java
File 
hyracks-fullstack/hyracks/hyracks-control/hyracks-control-nc/src/main/java/org/apache/hyracks/control/nc/io/IoRequestHandler.java:

PS3, Line 46: InterruptedException
Suppress SQ warning?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2417
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic02b456826ae7abc2619a7eec3f90b48717b0adb
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to