Michael Blow has posted comments on this change. Change subject: [NO ISSUE][TEST] Test flushing of empty component ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2421/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/FlushMetadataOnlyTest.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/FlushMetadataOnlyTest.java: PS1, Line 58: System.getProperty("user.dir") + File.separator + "src" + File.separator + "test" : + File.separator + "resources" + File.separator + "cc.conf" use FilePath.joinPath PS1, Line 68: System.out > Done add to class to trace test execution: @Rule public TestRule watcher = new TestMethodTracer(); PS1, Line 112: e.printStackTrace(); if anything, log- but not sure why not just propagate PS1, Line 113: Assert.fail(e.getMessage()); e.getMessage() should not be used in isolation- not sure why not just propagate exception? -- To view, visit https://asterix-gerrit.ics.uci.edu/2421 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If921323dfe03cbd70edc3a8ea8e01226d7527bb3 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
