Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2299] Set log type properly during modifications ......................................................................
Patch Set 1: Code-Review+2 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2424/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallback.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/opcallbacks/PrimaryIndexModificationOperationCallback.java: PS1, Line 109: log(logRecord); I hate the fact that the wait for this log to be flushed is implemented in LogManager and the flag isFlushed being set to false then true there as well. By the time this call returns, this log record will have isFlushed as true. While this has no impact in next UPDATE logs, it might in the future. Part of me wants to have the wait log as a new object, but we can consider this at a later stage. -- To view, visit https://asterix-gerrit.ics.uci.edu/2424 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcf93072ca0833cb24ba6719796f58df56384c3b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
