Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-2304] Ensure Flush is Finished in FlushRecoveryTest ......................................................................
Patch Set 7: Code-Review+2 (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2437/7/asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/api/common/AsterixHyracksIntegrationUtil.java: PS7, Line 140: stream() you can use forEach without stream https://asterix-gerrit.ics.uci.edu/#/c/2437/7/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/dataflow/StorageTestUtils.java: PS7, Line 191: 60000L use TimeUnit PS7, Line 193: .currentTimeMillis(); it isn't safe to use System.currentTimeMillis(), use System.nanoTime -- To view, visit https://asterix-gerrit.ics.uci.edu/2437 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1704c6606c7c7bef226ae31961c347c6ebb76c2a Gerrit-PatchSet: 7 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Wail Alkowaileet <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
