abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][STO] Improve the LSMIOOperationCallback interface. ......................................................................
Patch Set 3: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2455/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-btree/src/main/java/org/apache/hyracks/storage/am/lsm/btree/impls/ExternalBTree.java: PS1, Line 290: ExternalBTreeOpContext opCtx = createOpContext(NoOpOperationCallback.INSTA > move inside flushOnExit? Done https://asterix-gerrit.ics.uci.edu/#/c/2455/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/StubIOOperationCallback.java: PS1, Line 49: void afterFi > why is this synchronized? strange... this is only used in tests and my guess it was used in some tests where this used to do something. I couldn't find that though -- To view, visit https://asterix-gerrit.ics.uci.edu/2455 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7120c40a1a2256ed528dfd2e5853db9dba247c6 Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
