Michael Blow has posted comments on this change. Change subject: [NO ISSUE][TEST] Close HTTP requests upon thread interruption ......................................................................
Patch Set 1: (4 comments) https://asterix-gerrit.ics.uci.edu/#/c/2458/1/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/TestExecutor.java: PS1, Line 480: HttpResponse these are being leaked too, should return Closeable* and ensure these are closed once done with PS1, Line 482: CloseableHttpClient client = : HttpClients.custom().setRetryHandler(StandardHttpRequestRetryHandler.INSTANCE).build(); these are being leaked, should put in a try-with-resources PS1, Line 488: GlobalConfig.ASTERIX_LOGGER.log(Level.ERROR, e.getMessage(), e); Something helpful like "Exception executing {}", method, e PS1, Line 489: e.printStackTrace(); remove -- To view, visit https://asterix-gerrit.ics.uci.edu/2458 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39e43b8136df6b6a7965d033ca8892feda7394d4 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <bamou...@gmail.com> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-HasComments: Yes
