abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][TX] Ensure Uncommitted Atomic Txns Are Rolled back ......................................................................
Patch Set 3: I am not sure this works for deletes/upserts. Upsert and delete logs will only contain the previous value if it was in the in-memory component. For example, you do a delete and the previous value was on Disk, the log will only contain Delete(key). Assume then this component is flushed and maybe even merged. Then we would lose the original value forever. -- To view, visit https://asterix-gerrit.ics.uci.edu/2456 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8d5df630f1d9119002ef91da5c282da18901acc Gerrit-PatchSet: 3 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
