Till Westmann has posted comments on this change.

Change subject: [NO ISSUE] Change the working directory of UDF
......................................................................


Patch Set 1:

(5 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2448/1//COMMIT_MSG
Commit Message:

PS1, Line 18: binary_path
What is binary_path?


https://asterix-gerrit.ics.uci.edu/#/c/2448/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:

PS1, Line 406: // Check managix directory first. If not exists, check app home
remove comment?


PS1, Line 407: System.getProperty("user.home")
user.home is still an option?


PS1, Line 412: uninstall
pdfs missing in the path?


PS1, Line 415: // Check managix directory first. If not exists, check app home
remove comment?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2448
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409039d0ca054069853653b312b9f6187365a73b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkk...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to