Till Westmann has posted comments on this change.

Change subject: [NO ISSUE] Change the working directory of UDF
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

https://asterix-gerrit.ics.uci.edu/#/c/2448/2/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/external/ExternalLibraryUtils.java:

PS2, Line 411: System.getProperty("app.home", System.getProperty("user.home")
It'd probably be nice, if we wouldn't rely on having the same code in NCService 
and here. Instead we could pass the directory that NCService has determined to 
the NCDriver. But I'm not sure - and it'd be for another change anyway.


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2448
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I409039d0ca054069853653b312b9f6187365a73b
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Xikui Wang <xkk...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com>
Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to