Michael Blow has posted comments on this change.

Change subject: [NO ISSUE][CLUS] Log NC Status on Startup Tasks Request
......................................................................


Patch Set 1: Code-Review+2

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/2473/1/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java
File 
asterixdb/asterix-app/src/main/java/org/apache/asterix/app/replication/NcLifecycleCoordinator.java:

PS1, Line 150: new ArrayList<>()
it would be nice to be free to return Collections.emptyList() here, but we 
would need to refine the API to ensure extensions are prepared for this


PS1, Line 189: Arrays.stream
probably eclipse wouldn't have pointed this out, #amiright


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2473
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6e8f2c8a4144cb6f1768d1f78d819b0057f0056b
Gerrit-PatchSet: 1
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Murtadha Hubail <mhub...@apache.org>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Michael Blow <mb...@apache.org>
Gerrit-HasComments: Yes

Reply via email to