Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2280][IDX] Fix Index on Optional Nested Field ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2477/1/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/nested-index/index-selection/rtree-secondary-index-optional/rtree-secondary-index-optional.1.ddl.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/nested-index/index-selection/rtree-secondary-index-optional/rtree-secondary-index-optional.1.ddl.sqlpp: Line 45: create dataset MyData(MyRecord) primary key nested.id; Primary key type is not supposed to be optional, right? This one is optional though. How come ValidateUtil.validatePartitioningExpressions() does not fail in this case? Can we fix that method to fail and make primary key type non-optional in this testcase? -- To view, visit https://asterix-gerrit.ics.uci.edu/2477 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If098ff4a45db3c4e8b65d098cbb0940c8b7ab845 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
