abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][RT] Remove runtime from ActiveManager after it stops ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2494/1/asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java File asterixdb/asterix-active/src/main/java/org/apache/asterix/active/ActiveManager.java: PS1, Line 181: if (runtimes.containsKey(runtimeId)) { : runtime.stop(); : runtimes.remove(runtimeId); : } else { : LOGGER.info("Not stopping already stopped runtime " + runtimeId); : } I think we should simply stop here. Every runtime registers itself and should be responsible for unregistering itself. What we should do IMO is to have the deregisterRuntime be the only place where we remove the runtime and have it throw an exception if it doesn't find itself. -- To view, visit https://asterix-gerrit.ics.uci.edu/2494 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07c6398f46d4bb6d29b270aa71dee36e0d0917ae Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Xikui Wang <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
