Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2332][RT] Fix concurrency issue with RecordMerge and RecordRemoveFields ......................................................................
Patch Set 6: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2492/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeDescriptor.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordMergeDescriptor.java: Line 112: final IBinaryComparator STRING_BINARY_COMPARATOR = PointableHelper.createStringBinaryComparator(); let's make it lower case. This is not a static constant anymore https://asterix-gerrit.ics.uci.edu/#/c/2492/6/asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordRemoveFieldsEvalFactory.java File asterixdb/asterix-runtime/src/main/java/org/apache/asterix/runtime/evaluators/functions/records/RecordRemoveFieldsEvalFactory.java: Line 81: final IBinaryComparator STRING_BINARY_COMPARATOR = PointableHelper.createStringBinaryComparator(); let's make it lower case. This is not a static constant anymore -- To view, visit https://asterix-gerrit.ics.uci.edu/2492 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4c5db58184235474f7aed7e5a4b91b6b5685fc06 Gerrit-PatchSet: 6 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
