abdullah alamoudi has posted comments on this change. Change subject: [NO ISSUE][RT] Report all errors on SuperActivityOperatorNodePushable ......................................................................
Patch Set 4: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2498/4/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/rewriter/runtime/SuperActivityOperatorNodePushable.java: PS4, Line 198: Future<Void>[] tasks = new Future[operatorNodePushablesBFSOrder.size()]; : Throwable[] failures = new Throwable[operatorNodePushablesBFSOrder.size()]; > why not leave as lists? we can then remove the use of indexes and just ope Somehow I think this is better because I need a mechanism for all tasks to report their failures. using the indexes removes the need for synchronization, otherwise, we will have to use a blocking list Either way, I don't have a strong opinion. Thoughts? -- To view, visit https://asterix-gerrit.ics.uci.edu/2498 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbf31dd91303ce2f606734fcccb19270875266b3 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: abdullah alamoudi <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
