Michael Blow has posted comments on this change. Change subject: [NO ISSUE][TX] Log LogBufferTailReader Read Failures ......................................................................
Patch Set 1: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2499/1/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/logging/LogBufferTailReader.java: PS1, Line 50: "Unexpected log read status: " + status + ". Read log: " + logRecord.getLogRecordForDisplay() should we just log this in the log, not include in the exception? also, can we please log the bytes in byte buffer, starting at position() prior to calling readLogRecord (or even some bytes before if available) up to the current position at time of status != RecordReadStatus.OK (including some bytes after if available)? -- To view, visit https://asterix-gerrit.ics.uci.edu/2499 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba2edd8808e1d6de33b1b0fedd27263d99171b39 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
