Ildar Absalyamov has posted comments on this change. Change subject: [ASTERIXDB-2333][COMP] Allow filters to work alongside autogenerated keys ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2504/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java: PS1, Line 68: // match: commit OR distribute-result OR SINK - ... followed by: : // [insert to internal dataset with autogenerated id] - assign - project : // produce: insert - assign - assign* - project : // ** : // OR [insert to internal dataset with autogenerated id] - assign - [datasource scan] : // produce insert - assign - assign* - datasource scan Update the comment about matching plan structure accordingly https://asterix-gerrit.ics.uci.edu/#/c/2504/1/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/filters/filter-auto-key/filter-auto-key.3.query.sqlpp File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/filters/filter-auto-key/filter-auto-key.3.query.sqlpp: PS1, Line 22: select l.userName from UserLocations l; Please include the predicate that actually uses the filter field (I know it might be irrelevant to this particular issue, but still) -- To view, visit https://asterix-gerrit.ics.uci.edu/2504 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I450b4e20175992414955d59116e672450d442f81 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ildar Absalyamov <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
