Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-1708] Prevent log deletion during scan ......................................................................
Patch Set 13: (6 comments) Shouldn't this be proposed to the pre-rc branch? https://asterix-gerrit.ics.uci.edu/#/c/2256/13//COMMIT_MSG Commit Message: PS13, Line 7: [TX] https://asterix-gerrit.ics.uci.edu/#/c/2256/13/asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java File asterixdb/asterix-app/src/main/java/org/apache/asterix/app/nc/RecoveryManager.java: Line 110: private final TxnId recoveryTxnId = new TxnId(-1); static https://asterix-gerrit.ics.uci.edu/#/c/2256/12/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java: PS12, Line 93: ur > My first intuition was to just use MAX_VALUE but I think the LSN could feas if we reach Long.MAX_VALUE as LSN, this won't be our problem! https://asterix-gerrit.ics.uci.edu/#/c/2256/13/asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java File asterixdb/asterix-transactions/src/main/java/org/apache/asterix/transaction/management/service/recovery/CheckpointManager.java: PS13, Line 42: public make it private and move it up after LOGGER PS13, Line 74: final long minSecuredLSN = getMinSecuredLSN(); : if (minSecuredLSN != NO_SECURED_LSN && minFirstLSN >= getMinSecuredLSN()) { : return minSecuredLSN; : } comment from previous patch is still not addressed PS13, Line 93: private synchronized long getMinSecuredLSN() { : return securedLSNs.isEmpty() ? NO_SECURED_LSN : Collections.min(securedLSNs.values()); : } move private method to the end of the class -- To view, visit https://asterix-gerrit.ics.uci.edu/2256 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icff1a520af24c8fac8e5836cdbf46425b78b1260 Gerrit-PatchSet: 13 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ian Maxon <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
