Ahmed Eldawy has posted comments on this change. Change subject: [ASTERIXDB-1371][FUN][AQL][SQL] Add standard geometry data type and functions ......................................................................
Patch Set 18: (10 comments) I removed most of the redundant dependencies. However, two of them seem to be necessary so I couldn't remove them. See my replies on your individual comments. I can push the changes but I prefer to wait and see if there is something we need to do about the remaining two dependencies. https://asterix-gerrit.ics.uci.edu/#/c/2056/18/asterixdb/asterix-geo/pom.xml File asterixdb/asterix-geo/pom.xml: PS18, Line 96: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done PS18, Line 101: <version>3.7</version> > remove, this is inherited Done PS18, Line 106: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done PS18, Line 111: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done PS18, Line 116: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done PS18, Line 121: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done PS18, Line 126: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done PS18, Line 131: <version>0.9.4-SNAPSHOT</version> > <version>${project.version}</version> The build failed after removing this dependency with the error below. I replaced it with ${project.version} and it worked fine. -------- Build error when removed -------- [ERROR] The build could not read 1 project -> [Help 1] [ERROR] [ERROR] The project org.apache.asterix:asterix-geo:0.9.4-SNAPSHOT (/home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-geo/pom.xml) has 1 error [ERROR] 'dependencies.dependency.version' for org.apache.asterix:asterix-common:jar is missing. @ org.apache.asterix:asterix-geo:[unknown-version], /home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-geo/pom.xml, line 121, column 17 [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException ------------------------------------------------ PS18, Line 136: <version>0.3.4-SNAPSHOT</version> > remove, this is inherited Done https://asterix-gerrit.ics.uci.edu/#/c/2056/18/asterixdb/pom.xml File asterixdb/pom.xml: PS18, Line 1200: <version>1.9</version> > remove, this is inherited I didn't modify this dependency myself. However, I tried to remove the version and the compilation failed with the following error. [ERROR] The build could not read 1 project -> [Help 1] [ERROR] [ERROR] The project org.apache.asterix:asterix-transactions:0.9.4-SNAPSHOT (/home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-transactions/pom.xml) has 1 error [ERROR] 'dependencies.dependency.version' for commons-codec:commons-codec:jar is missing. @ org.apache.asterix:asterix-transactions:[unknown-version], /home/eldawy/workspace/asterixdb-pull/asterixdb/asterix-transactions/pom.xml, line 162, column 17 -- To view, visit https://asterix-gerrit.ics.uci.edu/2056 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cddeffea42e85469b6fc38f361bd98e64025289 Gerrit-PatchSet: 18 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Ahmed Eldawy <eld...@cs.umn.edu> Gerrit-Reviewer: Ahmed Eldawy <aseld...@gmail.com> Gerrit-Reviewer: Ian Maxon <ima...@apache.org> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
