Steven Jacobs has posted comments on this change. Change subject: [ASTERIXDB-2333][COMP] Allow filters to work alongside autogenerated keys ......................................................................
Patch Set 4: (5 comments) https://asterix-gerrit.ics.uci.edu/#/c/2504/4/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/IntroduceAutogenerateIDRule.java: Line 123: AssignOperator assignOp = (AssignOperator) parentOp; > do we still need this? see 166 comment Line 138: (AbstractLogicalOperator) grandparentOp.getInputs().get(0).getValue(); > Do the previous statements make sure there is an input for this op? Done Line 163: if (hasFilter) { > if we do 166 change, do we still need this boolean? see 166 Line 166: VariableUtilities.substituteVariables(assignOp, inputRecord, v, context); > change this to use new assignChildOp? The issue here is that when we have a filter there are two assign operators instead of one (meaning there has to be one extra call to substitute variables and computeAndSet... The two operators will be the same in the non-filter case, and the extra call won't happen Line 172: context.computeAndSetTypeEnvironmentForOperator(assignOp); > same see 166 -- To view, visit https://asterix-gerrit.ics.uci.edu/2504 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I450b4e20175992414955d59116e672450d442f81 Gerrit-PatchSet: 4 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Ildar Absalyamov <ildar.absalya...@gmail.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Steven Jacobs <sjaco...@ucr.edu> Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com> Gerrit-HasComments: Yes
