abdullah alamoudi has posted comments on this change. Change subject: [ASTERIXDB-2280][IDX] Fix Index on Optional Nested Field ......................................................................
Patch Set 10: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2477/10/asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java File asterixdb/asterix-om/src/main/java/org/apache/asterix/om/types/ARecordType.java: PS10, Line 246: nullable = true; just return true? get rid of nullable variable? PS10, Line 254: subRecordType this could class cast? what if it is not a record. should we move the check above out of the block? -- To view, visit https://asterix-gerrit.ics.uci.edu/2477 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: If098ff4a45db3c4e8b65d098cbb0940c8b7ab845 Gerrit-PatchSet: 10 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <dmitry.lycha...@couchbase.com> Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Luo Chen <cl...@uci.edu> Gerrit-Reviewer: Taewoo Kim <taew...@uci.edu> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
