Murtadha Hubail has posted comments on this change. Change subject: [ASTERIXDB-1424][RT] IPv6 Support ......................................................................
Patch Set 1: (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2546/1/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java: PS1, Line 77: if (InetAddressUtils.isIPv6Address(host)) { : return "[" + host + "]:" + port; : } else { : return host + ":" + port; : } call toHost(string, string) PS1, Line 104: hostname.length() should we make this and null hostname illegalArgException -- To view, visit https://asterix-gerrit.ics.uci.edu/2546 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fdb97b89529632a47ecab12fb4c62c2ec7082e5 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-HasComments: Yes
