Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2344] LIMIT pushdown for primary index ......................................................................
Patch Set 8: (3 comments) Also: 1) BinaryBooleanInspector.getBooleanValue() should throw HyracksDataException when input value is not boolean (instead of IllegalStateException) 2) ITupleFilter.accept() should throw HyracksDataException instead of Exception 3) CB verification test currently fails because of the signature change in DataSource.buildDatasourceScanRuntime(). We'll need to create a coordinated change on our side. https://asterix-gerrit.ics.uci.edu/#/c/2541/8/asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSource.java File asterixdb/asterix-metadata/src/main/java/org/apache/asterix/metadata/declared/DataSource.java: Line 164: ITupleFilterFactory tupleFilterFactory, long outputLimit, IOperatorSchema opSchema, All implementations that do not support tupleFilterFactory and outputLimit should fail with internal error when non-null tuppleFilterFactory and/or outputLimit are passed to them. https://asterix-gerrit.ics.uci.edu/#/c/2541/8/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DataSourceScanOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/DataSourceScanOperator.java: Line 140: public Mutable<ILogicalExpression> getSelectCondition() { The following visitors need to be updated to handle this new expression in their visitDataScanOperator() implementations: - LogicalOperatorDeepCopyWithNewVariablesVisitor - OperatorDeepCopyVisitor - SubstituteVariableVisitor - UsedVariableVisitor - LogicalOperatorPrettyPrintVisitorJson - LogicalOperatorDotVisitor https://asterix-gerrit.ics.uci.edu/#/c/2541/8/hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/UnnestMapOperator.java File hyracks-fullstack/algebricks/algebricks-core/src/main/java/org/apache/hyracks/algebricks/core/algebra/operators/logical/UnnestMapOperator.java: Line 70: public Mutable<ILogicalExpression> getSelectCondition() { The following visitors need to be updated to handle this new expression in their visitUnnestMapOperator() implementations: - LogicalOperatorDotVisitor, - LogicalOperatorPrettyPrintVisitorJson - SubstituteVariableVisitor - OperatorDeepCopyVisitor - LogicalOperatorDeepCopyWithNewVariablesVisitor - IsomorphismOperatorVisitor -- To view, visit https://asterix-gerrit.ics.uci.edu/2541 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I824fcad79995325e12a1a81d629160025294b915 Gerrit-PatchSet: 8 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim (please use [email protected]) <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
