Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2355][SQL] Incorrect error reporting by SQL++ parser ......................................................................
Patch Set 2: (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2572/2/asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java File asterixdb/asterix-app/src/test/java/org/apache/asterix/test/common/ResultExtractor.java: PS2, Line 179: throw new Exception("Request reported error but not an errorCount"); : } : throw new Exception(errors.asText()); > why are we using generic Exception here? It's a testcase. AsterixException should not be used because it expects the message argument to be a formatting pattern, so should not be given an arbitrary text. There're more places where this needs to be addressed, but it should be done on master branch. -- To view, visit https://asterix-gerrit.ics.uci.edu/2572 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id68f2b039c8198509658a90a60b8a8dc95361a84 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-HasComments: Yes
