Xikui Wang has posted comments on this change.

Change subject: Add push-based channels and improve broker notifications
......................................................................


Patch Set 3:

(4 comments)

some minor comments...

https://asterix-gerrit.ics.uci.edu/#/c/2551/3/asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/lang/statement/CreateChannelStatement.java:

Line 250:         if (!push) {
it would be better to refactor this into stmt/query/exprs... it's ok to me to 
leave it like this for now...


https://asterix-gerrit.ics.uci.edu/#/c/2551/3/asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/rules/InsertBrokerNotifierForChannelRule.java:

Line 150:         if 
(!channelExecutionVar.toString().equals("$$channelExecutionTime")) {
is this name a constant used somewhere else too? it would be better to unify 
the usages of this constant so it can be easily changed later...


Line 182:     private DelegateOperator createNotifyBrokerPlan(LogicalVariable 
brokerEndpointVar,
I think if you want to make this method cleaner, you would need to extract the 
different part into a separate method, and depending on the `push` to decide 
whether you want to call that additional method...


https://asterix-gerrit.ics.uci.edu/#/c/2551/3/asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java
File 
asterix-bad/src/main/java/org/apache/asterix/bad/runtime/NotifyBrokerRuntime.java:

Line 179:             if (push) {
does the order matter here (which i guess is yes). if not, can we group these 
two pushes?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2551
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3c7cae0f015d6bc01dd912499565bb12c15abc3
Gerrit-PatchSet: 3
Gerrit-Project: asterixdb-bad
Gerrit-Branch: master
Gerrit-Owner: Steven Jacobs <sjaco...@ucr.edu>
Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Xikui Wang <xkk...@gmail.com>
Gerrit-HasComments: Yes

Reply via email to