Murtadha Hubail has posted comments on this change. Change subject: [NO ISSUE][OTR] Eliminate Per Tuple Object Creation ......................................................................
Patch Set 1: (6 comments) https://asterix-gerrit.ics.uci.edu/#/c/2587/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/ChainedLSMDiskComponentBulkLoader.java: PS1, Line 55: for (int i = 0; i < bulkloaderChain.size(); i++) { : t = bulkloaderChain.get(i).add(t); : } > can we make IChainedComponentBulkLoader.add() not throw checked exceptions? Done. ForEach() will still create an iterator. PS1, Line 72: for (int i = 0; i < bulkloaderChain.size(); i++) { : t = bulkloaderChain.get(i).delete(t); : } > can we make IChainedComponentBulkLoader.delete() not throw checked exceptio Done. ForEach() will still create an iterator. https://asterix-gerrit.ics.uci.edu/#/c/2587/1/hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java File hyracks-fullstack/hyracks/hyracks-storage-am-lsm-common/src/main/java/org/apache/hyracks/storage/am/lsm/common/impls/LSMHarness.java: PS1, Line 192: components.size() > make invariant Done PS1, Line 208: components.size() > make invariant Done PS1, Line 379: ctx.getComponentHolder() > extract local Done PS1, Line 379: ctx.getComponentHolder().size() > make loop invariant Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2587 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d3a5472c70c4564290daeb6e99d508000521119 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <jenk...@fulliautomatix.ics.uci.edu> Gerrit-Reviewer: Michael Blow <mb...@apache.org> Gerrit-Reviewer: Murtadha Hubail <mhub...@apache.org> Gerrit-Reviewer: Till Westmann <ti...@apache.org> Gerrit-Reviewer: abdullah alamoudi <bamou...@gmail.com> Gerrit-HasComments: Yes
