Dmitry Lychagin has posted comments on this change. Change subject: [ASTERIXDB-2344] LIMIT pushdown for primary index ......................................................................
Patch Set 9: (3 comments) https://asterix-gerrit.ics.uci.edu/#/c/2541/9/hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java File hyracks-fullstack/hyracks/hyracks-storage-am-common/src/main/java/org/apache/hyracks/storage/am/common/dataflow/IndexSearchOperatorNodePushable.java: Line 211: finished = false; also set outputCount = 0 here Line 238: if (tupleFilter != null && !tupleFilter.accept(referenceFilterTuple.reset(tuple))) { > Done. I added a check in the optimization rule. Please let me know if that yes, I think that check in the rule works Line 268: FrameUtils.appendConcatToWriter(writer, appender, accessor, tupleIndex, > I think currently this is OK because we won't push LIMIT into here if retai Returning more data is ok because there's still a LIMIT operator guarding the final result, but not checking the tuple filter is wrong because the original SELECT with that filter was removed from the plan. So any tuple returned from this operator should satisfy the tupleFilter. If 'retainInput=true' cannot happen when there's a tupleFilter, then let's add a sanity check to the constructor and fail with internal error if retainInput = true && tupleFilter != null. -- To view, visit https://asterix-gerrit.ics.uci.edu/2541 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I824fcad79995325e12a1a81d629160025294b915 Gerrit-PatchSet: 9 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim (please use [email protected]) <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: Yes
