Michael Blow has posted comments on this change. Change subject: [ASTERIXDB-1424][RT] IPv6 Support ......................................................................
Patch Set 5: Verified+1 (1 comment) https://asterix-gerrit.ics.uci.edu/#/c/2546/1/hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java File hyracks-fullstack/hyracks/hyracks-util/src/main/java/org/apache/hyracks/util/NetworkUtil.java: PS1, Line 77: : public static String toHostPort(InetSocketAddress address) { : return toHostPort(address.getHostString(), address.getPort()); : } : > call toHost(string, string) i'm all about premature optimization, and was avoiding converting ints to strings -- To view, visit https://asterix-gerrit.ics.uci.edu/2546 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fdb97b89529632a47ecab12fb4c62c2ec7082e5 Gerrit-PatchSet: 5 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Michael Blow <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Michael Blow <[email protected]> Gerrit-Reviewer: Murtadha Hubail <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
