Taewoo Kim has posted comments on this change.

Change subject: [ASTERIXDB-2356][SQL] Syntax error when parsing CASE expression
......................................................................


Patch Set 2: Code-Review+2

(1 comment)

LGTM - only one minor comment

https://asterix-gerrit.ics.uci.edu/#/c/2571/2/asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml
File asterixdb/asterix-app/src/test/resources/runtimets/testsuite_sqlpp.xml:

Line 3598:         <output-dir compare="Text">case_05</output-dir>
I know this is not related to your change. But, this should be fixed? case_05 
--> case_07?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/2571
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9ded0d7a20aaa9cd81240821f5b903f262b0b6a
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <[email protected]>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Taewoo Kim <[email protected]>
Gerrit-Reviewer: Till Westmann <[email protected]>
Gerrit-HasComments: Yes

Reply via email to