Xikui Wang has posted comments on this change. Change subject: [ASTERIXDB-2373][HYR,CLUS] Allow upsert of JobSpecs for Deployed Jobs ......................................................................
Patch Set 1: (1 comment) @Till, can you have a look at the naming problem that I have here. The rests are fine. https://asterix-gerrit.ics.uci.edu/#/c/2619/1/hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java File hyracks-fullstack/hyracks/hyracks-api/src/main/java/org/apache/hyracks/api/client/HyracksClientInterfaceRemoteProxy.java: PS1, Line 101: upsertDeployedJobSpec > The reason I went with upsert is because this is technically working with a I totally understand the behavior of this method. My point was, in AsterixDB I think, `upsert` is used specifically for upserting records, thus I think it might not be the best choice to use it here. Imagine someone wants to look for methods related to upsert data records. Every time this one will come up... When this happens, people will look at the git log to see who added it. Meanwhile, I don't have a better word to describe this as well... let me bring in naming master Till to this patch. If he's happy about it, i'm sure it's ok. -- To view, visit https://asterix-gerrit.ics.uci.edu/2619 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01fd5d43896d520fe75e1007d7bd39324f6f6e4b Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Steven Jacobs <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Steven Jacobs <[email protected]> Gerrit-Reviewer: Xikui Wang <[email protected]> Gerrit-HasComments: Yes
