Till Westmann has posted comments on this change. Change subject: [ASTERIXDB-2378][SQL] Add “DIV”, “MOD”, change “/“ for integers ......................................................................
Patch Set 1: Code-Review+2 (2 comments) https://asterix-gerrit.ics.uci.edu/#/c/2630/1/asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java File asterixdb/asterix-algebra/src/main/java/org/apache/asterix/optimizer/rules/am/AbstractIntroduceAccessMethodRule.java: PS1, Line 92: that retain the original field variable What does this mean? https://asterix-gerrit.ics.uci.edu/#/c/2630/1/asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/divide_int8/divide_int8.1.adm File asterixdb/asterix-app/src/test/resources/runtimets/results/numeric/divide_int8/divide_int8.1.adm: PS1, Line 1: 1.0 Should we change the printers to not print ".0" here? -- To view, visit https://asterix-gerrit.ics.uci.edu/2630 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c6b0704ce60a03dd3c10e1c75cb9761acc56536 Gerrit-PatchSet: 1 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
