Till Westmann has posted comments on this change. Change subject: [NO ISSUE] SQL++ doc updates ......................................................................
Patch Set 2: (4 comments) These were docs updates that we did before the implementation was final ... addressed all your comments. https://asterix-gerrit.ics.uci.edu/#/c/2631/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/2_expr.md: Line 53: | *, /, % | Multiplication, division, modulo | > there're no DIV and MOD on release-0.9.4-pre-rc branch. The commit that int Done Line 75: | *, /, % | Multiply, divide, modulo | SELECT VALUE 4 / 2.0; | > same as above. no DIV/MOD on release-0.9.4-pre-rc branch. We need to rever Done https://asterix-gerrit.ics.uci.edu/#/c/2631/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/3_declare_dataverse.md: PS1, Line 24: dataverses > this is not the only place where we talk about dataverses. Why rename it he Done https://asterix-gerrit.ics.uci.edu/#/c/2631/1/asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md File asterixdb/asterix-doc/src/main/markdown/sqlpp/3_query.md: Line 1204: ### <a id="Column_aliases">Column Aliases</a> > why comment out? This is still valid. Column aliases can be used in ORDER B Done -- To view, visit https://asterix-gerrit.ics.uci.edu/2631 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cdb400893609c578b6467586bcc2d15f2106996 Gerrit-PatchSet: 2 Gerrit-Project: asterixdb Gerrit-Branch: release-0.9.4-pre-rc Gerrit-Owner: Till Westmann <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Till Westmann <[email protected]> Gerrit-HasComments: Yes
