Luo Chen has posted comments on this change. Change subject: [ASTERIXDB-2344] LIMIT pushdown for primary index ......................................................................
Patch Set 17: > LGTM. I only have a few minor comments. > > #1. Do we want to keep the optimizer tests? or just use runtime > test framework? It looks like you are using the runtime test to > generate the plan and check it without introducing the optimizer > tests. > > #2. Can you add a description to each test? What are they supposed > to check? > > #3. Before declaring outputLimit, selectCondition, and > tupleFilterFactory variables in each class, can we add a simple > comment about them? What's the purpose of them? 1. I think optimizer tests have already been removed. It seems optimizer tests cannot print out detailed variable information, which is needed to test this feature. So I just use "explain" query for this purpose. 2. Done. 3. Done. -- To view, visit https://asterix-gerrit.ics.uci.edu/2541 To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings Gerrit-MessageType: comment Gerrit-Change-Id: I824fcad79995325e12a1a81d629160025294b915 Gerrit-PatchSet: 17 Gerrit-Project: asterixdb Gerrit-Branch: master Gerrit-Owner: Luo Chen <[email protected]> Gerrit-Reviewer: Anon. E. Moose #1000171 Gerrit-Reviewer: Dmitry Lychagin <[email protected]> Gerrit-Reviewer: Ian Maxon <[email protected]> Gerrit-Reviewer: Jenkins <[email protected]> Gerrit-Reviewer: Luo Chen <[email protected]> Gerrit-Reviewer: Taewoo Kim (please use [email protected]) <[email protected]> Gerrit-Reviewer: Taewoo Kim <[email protected]> Gerrit-Reviewer: abdullah alamoudi <[email protected]> Gerrit-HasComments: No
